Add verifiable data registry#6
Merged
Merged
Conversation
Renamed from did to registry Introduced a types.go with interfaces and types Moved all config related things to config.go Removed obsolete engine tests
Simple doc creator which creates a key and creates a simple did document. Needs more tests etc.
Added generator to the make file
Codecov Report
|
Removed obsolete config from vdr
Makes it easyer to implement engine methods
Ignore pem files
woutslakhorst
marked this pull request as ready for review
January 22, 2021 09:18
woutslakhorst
requested changes
Jan 22, 2021
Renamed everything from Registry to VDR Fixed comments and docs Added more test coverage
reinkrul
reviewed
Jan 22, 2021
reinkrul
requested changes
Jan 22, 2021
reinkrul
self-requested a review
January 25, 2021 08:09
* Ignore pem files in the root * Fix http prefix from address * Specify DID documents used in the api should be according to the nuts spec * Removed unused vdr config options from readme * Always return a deep copy from the memory store to prevent modification * Renamed a bunch of vars and types
Code coverage Naming issues
reinkrul
approved these changes
Jan 25, 2021
woutslakhorst
approved these changes
Jan 25, 2021
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation of RFC006.